Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8912862f authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

mlxsw: spectrum_buffers: Fix pool value handling in mlxsw_sp_sb_tc_pool_bind_set 



Pool index has to be converted by get_pool helper to work correctly for
egress pool. In mlxsw the egress pool index starts from 0.

Fixes: 0f433fa0 ("mlxsw: spectrum_buffers: Implement shared buffer configuration")
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Reviewed-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 56cff471

drivers/net/ethernet/mellanox/mlxsw/spectrum_buffers.c

+4 −8
Original line number Diff line number Diff line
@@ -717,22 +717,18 @@ int mlxsw_sp_sb_tc_pool_bind_set(struct mlxsw_core_port *mlxsw_core_port, 
	u8 local_port = mlxsw_sp_port->local_port;

	u8 pg_buff = tc_index;

	enum mlxsw_reg_sbxx_dir dir = pool_type;

	u8 pool = pool_index;

	u8 pool = pool_get(pool_index);

	u32 max_buff;

	int err;



	if (dir != dir_get(pool_index))

		return -EINVAL;



	err = mlxsw_sp_sb_threshold_in(mlxsw_sp, pool, dir,

				       threshold, &max_buff);

	if (err)

		return err;



	if (pool_type == DEVLINK_SB_POOL_TYPE_EGRESS) {

		if (pool < MLXSW_SP_SB_POOL_COUNT)

			return -EINVAL;

		pool -= MLXSW_SP_SB_POOL_COUNT;

	} else if (pool >= MLXSW_SP_SB_POOL_COUNT) {

		return -EINVAL;

	}

	return mlxsw_sp_sb_cm_write(mlxsw_sp, local_port, pg_buff, dir,

				    0, max_buff, pool);

}