Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87f818b3 authored by Bhaktipriya Shridhar's avatar Bhaktipriya Shridhar Committed by Sebastian Reichel
Browse files

power: intel_mid_battery: Remove deprecated create_singlethread_workqueue 



The workqueue "monitor_wqueue" is used to monitor the PMIC battery status.
It queues a single work item (pbi->monitor_battery) and hence doesn't
require ordering. Hence, alloc_workqueue has been used to replace the
deprecated create_singlethread_workqueue instance.

Since PMIC battery status needs to be monitored for any change, the
WQ_MEM_RECLAIM flag has been set to ensure forward progress under memory
pressure.

Since there is a single work item, explicit concurrency
limit is unnecessary here.

Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent d8a69251

drivers/power/supply/intel_mid_battery.c

+1 −2
Original line number Diff line number Diff line
@@ -689,8 +689,7 @@ static int probe(int irq, struct device *dev) 
	/* initialize all required framework before enabling interrupts */

	INIT_WORK(&pbi->handler, pmic_battery_handle_intrpt);

	INIT_DELAYED_WORK(&pbi->monitor_battery, pmic_battery_monitor);

	pbi->monitor_wqueue =

			create_singlethread_workqueue(dev_name(dev));

	pbi->monitor_wqueue = alloc_workqueue(dev_name(dev), WQ_MEM_RECLAIM, 0);

	if (!pbi->monitor_wqueue) {

		dev_err(dev, "%s(): wqueue init failed\n", __func__);

		retval = -ESRCH;