Commit 87e57399 authored Jan 25, 2016 by Thadeu Lima de Souza Cascardo Committed by David S. Miller Jan 25, 2016

sit: set rtnl_link_ops before calling register_netdevice

When creating a SIT tunnel with ip tunnel, rtnl_link_ops is not set before
ipip6_tunnel_create is called. When register_netdevice is called, there is
no linkinfo attribute in the NEWLINK message because of that.

Setting rtnl_link_ops before calling register_netdevice fixes that.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 05f3b50e

net/ipv6/sit.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -201,14 +201,14 @@ static int ipip6_tunnel_create(struct net_device *dev)
		if ((__force u16)t->parms.i_flags & SIT_ISATAP)
		dev->priv_flags \|= IFF_ISATAP;

		dev->rtnl_link_ops = &sit_link_ops;

		err = register_netdevice(dev);
		if (err < 0)
		goto out;

		ipip6_tunnel_clone_6rd(dev, sitn);

		dev->rtnl_link_ops = &sit_link_ops;

		dev_hold(dev);

		ipip6_tunnel_link(sitn, t);