Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 876e7a8a authored by Andrew Duggan's avatar Andrew Duggan Committed by Jiri Kosina
Browse files

HID: rmi: fix masks for x and w_x data 



The F11 data in the HID report contains four bits of data for w_x and the least significant bits
of x. Currently only the first three bits are being used which is resulting in small jumps in
the position data on the x axis and in the w_x data.

Signed-off-by: default avatarAndrew Duggan <aduggan@synaptics.com>
Reviewed-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent b668fdce

drivers/hid/hid-rmi.c

+2 −2
Original line number Diff line number Diff line
@@ -277,9 +277,9 @@ static void rmi_f11_process_touch(struct rmi_data *hdata, int slot, 
	input_mt_report_slot_state(hdata->input, MT_TOOL_FINGER,

			finger_state == 0x01);

	if (finger_state == 0x01) {

		x = (touch_data[0] << 4) | (touch_data[2] & 0x07);

		x = (touch_data[0] << 4) | (touch_data[2] & 0x0F);

		y = (touch_data[1] << 4) | (touch_data[2] >> 4);

		wx = touch_data[3] & 0x07;

		wx = touch_data[3] & 0x0F;

		wy = touch_data[3] >> 4;

		wide = (wx > wy);

		major = max(wx, wy);