Commit 86fc4998 authored Apr 12, 2012 by Jesper Juhl Committed by Mark Brown Apr 13, 2012

ASoC: cs42l73: don't use negative array index



If cs42l73_get_mclkx_coeff() returns < 0 (which it can) in
sound/soc/codecs/cs42l73.c::cs42l73_set_mclk(), then we'll be using
the (negative) return value as array index on the very next line of
code - that's bad.

Catch the negative return value and propagate it to the caller (which
checks for it) and things are a bit more sane :-)

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 7e1f7c8a

sound/soc/codecs/cs42l73.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -929,6 +929,8 @@ static int cs42l73_set_mclk(struct snd_soc_dai *dai, unsigned int freq)

		/* MCLKX -> MCLK */
		mclkx_coeff = cs42l73_get_mclkx_coeff(freq);
		if (mclkx_coeff < 0)
		return mclkx_coeff;

		mclk = cs42l73_mclkx_coeffs[mclkx_coeff].mclkx /
		cs42l73_mclkx_coeffs[mclkx_coeff].ratio;