Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86a2b9cf authored by Veaceslav Falico's avatar Veaceslav Falico Committed by David S. Miller
Browse files

bonding: ratelimit pr_warn()s in 802.3ad mode 



Only ratelimit the ones that might spam, omiting the ones from
enslave/deslave.

CC: Jay Vosburgh <fubar@us.ibm.com>
CC: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: default avatarVeaceslav Falico <vfalico@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d37d8ac1

drivers/net/bonding/bond_3ad.c

+17 −17
Original line number Diff line number Diff line
@@ -1284,7 +1284,7 @@ static void ad_port_selection_logic(struct port *port) 
			/* meaning: the port was related to an aggregator

			 * but was not on the aggregator port list

			 */

			pr_warn("%s: Warning: Port %d (on %s) was related to aggregator %d but was not on its port list\n",

			pr_warn_ratelimited("%s: Warning: Port %d (on %s) was related to aggregator %d but was not on its port list\n",

					    port->slave->bond->dev->name,

					    port->actor_port_number,

					    port->slave->dev->name,
@@ -1445,7 +1445,7 @@ static struct aggregator *ad_agg_selection_test(struct aggregator *best, 
		break;



	default:

		pr_warn("%s: Impossible agg select mode %d\n",

		pr_warn_ratelimited("%s: Impossible agg select mode %d\n",

				    curr->slave->bond->dev->name,

				    __get_agg_selection_mode(curr->lag_ports));

		break;
@@ -1560,7 +1560,7 @@ static void ad_agg_selection_logic(struct aggregator *agg) 


		/* check if any partner replys */

		if (best->is_individual) {

			pr_warn("%s: Warning: No 802.3ad response from the link partner for any adapters in the bond\n",

			pr_warn_ratelimited("%s: Warning: No 802.3ad response from the link partner for any adapters in the bond\n",

					    best->slave ?

					    best->slave->bond->dev->name : "NULL");

		}
@@ -2081,7 +2081,7 @@ void bond_3ad_state_machine_handler(struct work_struct *work) 
		/* select the active aggregator for the bond */

		if (port) {

			if (!port->slave) {

				pr_warn("%s: Warning: bond's first port is uninitialized\n",

				pr_warn_ratelimited("%s: Warning: bond's first port is uninitialized\n",

						    bond->dev->name);

				goto re_arm;

			}
@@ -2096,7 +2096,7 @@ void bond_3ad_state_machine_handler(struct work_struct *work) 
	bond_for_each_slave_rcu(bond, slave, iter) {

		port = &(SLAVE_AD_INFO(slave).port);

		if (!port->slave) {

			pr_warn("%s: Warning: Found an uninitialized port\n",

			pr_warn_ratelimited("%s: Warning: Found an uninitialized port\n",

					    bond->dev->name);

			goto re_arm;

		}
@@ -2158,7 +2158,7 @@ static int bond_3ad_rx_indication(struct lacpdu *lacpdu, struct slave *slave, 
		port = &(SLAVE_AD_INFO(slave).port);



		if (!port->slave) {

			pr_warn("%s: Warning: port of slave %s is uninitialized\n",

			pr_warn_ratelimited("%s: Warning: port of slave %s is uninitialized\n",

					    slave->dev->name, slave->bond->dev->name);

			return ret;

		}