Commit 8681a1d4 authored Sep 27, 2016 by Matthew Kilgore Committed by Greg Kroah-Hartman Sep 28, 2016

Fixes: 3d44a78f ("staging: rtl8712: Remove unnecessary 'else'")



An "unnecessary" 'else' was removed due to complains from checkpatch.pl
as it is preceded by a 'return', however the 'else' branch is necessary
as an earlier branch of the 'if' falls through. By removing the 'else',
that route now hits the 'break' and the 'while' loop exits prematurely.

This commit reverts that change and puts the original 'else' back in
place.

Signed-off-by: Matthew Kilgore <mattkilgore12@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1d0a2c5f

drivers/staging/rtl8712/rtl8712_recv.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -508,6 +508,7 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
		plist = plist->next;
		else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
		return false;
		else
		break;
		}
		list_del_init(&(prframe->u.hdr.list));