Commit 85f3f14e authored Jul 17, 2014 by H Hartley Sweeten Committed by Greg Kroah-Hartman Jul 17, 2014

staging: comedi: das08: remove use of comedi_error()



The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.

Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b07262b0

drivers/staging/comedi/drivers/das08.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -273,7 +273,7 @@ static int das08_ai_rinsn(struct comedi_device dev, struct comedi_subdevice s,
		else
		data[n] = (1 << 15) - (lsb \| (msb & 0x7f) << 8);
		} else {
		comedi_error(dev, "bug! unknown ai encoding");
		dev_err(dev->class_dev, "bug! unknown ai encoding\n");
		return -1;
		}
		}