Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8599396b authored by Tejun Heo's avatar Tejun Heo Committed by Miklos Szeredi
Browse files

fuse: implement unsolicited notification 



Clients always used to write only in response to read requests.  To
implement poll efficiently, clients should be able to issue
unsolicited notifications.  This patch implements basic notification
support.

Zero fuse_out_header.unique is now accepted and considered unsolicited
notification and the error field contains notification code.  This
patch doesn't implement any actual notification.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@suse.cz>
parent acf99433

fs/fuse/dev.c

+25 −2
Original line number Original line Diff line number Diff line
@@ -816,6 +816,15 @@ static ssize_t fuse_dev_read(struct kiocb *iocb, const struct iovec *iov, 
	return err;

	return err;

}

}





static int fuse_notify(struct fuse_conn *fc, enum fuse_notify_code code,

		       unsigned int size, struct fuse_copy_state *cs)

{

	switch (code) {

	default:

		return -EINVAL;

	}

}



/* Look up request on processing list by unique ID */

/* Look up request on processing list by unique ID */

static struct fuse_req *request_find(struct fuse_conn *fc, u64 unique)

static struct fuse_req *request_find(struct fuse_conn *fc, u64 unique)

{

{
@@ -879,9 +888,23 @@ static ssize_t fuse_dev_write(struct kiocb *iocb, const struct iovec *iov, 
	err = fuse_copy_one(&cs, &oh, sizeof(oh));

	err = fuse_copy_one(&cs, &oh, sizeof(oh));

	if (err)

	if (err)

		goto err_finish;

		goto err_finish;



	err = -EINVAL;

	if (oh.len != nbytes)

		goto err_finish;



	/*

	 * Zero oh.unique indicates unsolicited notification message

	 * and error contains notification code.

	 */

	if (!oh.unique) {

		err = fuse_notify(fc, oh.error, nbytes - sizeof(oh), &cs);

		fuse_copy_finish(&cs);

		return err ? err : nbytes;

	}



	err = -EINVAL;

	err = -EINVAL;

	if (!oh.unique || oh.error <= -1000 || oh.error > 0 ||

	if (oh.error <= -1000 || oh.error > 0)

	    oh.len != nbytes)

		goto err_finish;

		goto err_finish;





	spin_lock(&fc->lock);

	spin_lock(&fc->lock);

include/linux/fuse.h

+4 −0
Original line number Original line Diff line number Diff line
@@ -203,6 +203,10 @@ enum fuse_opcode { 
	FUSE_IOCTL         = 39,

	FUSE_IOCTL         = 39,

};

};





enum fuse_notify_code {

	FUSE_NOTIFY_CODE_MAX,

};



/* The read buffer is required to be at least 8k, but may be much larger */

/* The read buffer is required to be at least 8k, but may be much larger */

#define FUSE_MIN_READ_BUFFER 8192

#define FUSE_MIN_READ_BUFFER 8192