Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84dfe03a authored by Alexander Usyskin's avatar Alexander Usyskin Committed by Greg Kroah-Hartman
Browse files

mei: hbm: fix error in state check logic 



Use || instead && in state check.
The latter is bogus and leads to following warning:

drivers/misc/mei/hbm.c:1212:46: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]

Fixes: 70ef835c ("mei: support for dynamic clients")
Reported-by: default avatarDavid Binderman <dcb314@hotmail.com>
Signed-off-by: default avatarAlexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fb727077

drivers/misc/mei/hbm.c

+1 −1
Original line number Diff line number Diff line
@@ -1209,7 +1209,7 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr) 
		 * after the host receives the enum_resp

		 * message clients may be added or removed

		 */

		if (dev->hbm_state <= MEI_HBM_ENUM_CLIENTS &&

		if (dev->hbm_state <= MEI_HBM_ENUM_CLIENTS ||

		    dev->hbm_state >= MEI_HBM_STOPPED) {

			dev_err(dev->dev, "hbm: add client: state mismatch, [%d, %d]\n",

				dev->dev_state, dev->hbm_state);