Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83f0e27c authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Paul Mundt
Browse files

vt8623fb: use display information in info not in var for panning 



We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ondrej Zajicek <santiago@crfreenet.org>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent c6990b77

drivers/video/vt8623fb.c

+5 −4
Original line number Diff line number Diff line
@@ -620,13 +620,14 @@ static int vt8623fb_pan_display(struct fb_var_screeninfo *var, struct fb_info *i 
	unsigned int offset;



	/* Calculate the offset */

	if (var->bits_per_pixel == 0) {

		offset = (var->yoffset / 16) * var->xres_virtual + var->xoffset;

	if (info->var.bits_per_pixel == 0) {

		offset = (var->yoffset / 16) * info->var.xres_virtual

		       + var->xoffset;

		offset = offset >> 3;

	} else {

		offset = (var->yoffset * info->fix.line_length) +

			 (var->xoffset * var->bits_per_pixel / 8);

		offset = offset >> ((var->bits_per_pixel == 4) ? 2 : 1);

			 (var->xoffset * info->var.bits_per_pixel / 8);

		offset = offset >> ((info->var.bits_per_pixel == 4) ? 2 : 1);

	}



	/* Set the offset */