Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83ab7dad authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Alexandre Belloni
Browse files

rtc: pcf2123: Add missing error code assignment before test 



It is likely that checking the result of 'pcf2123_write_reg' is expected
here.
Also fix a small style issue. The '{' at the beginning of the function
is misplaced.

Fixes: 809b453b ("rtc: pcf2123: clean up writes to the rtc chip")

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 04940631

drivers/rtc/rtc-pcf2123.c

+3 −2
Original line number Diff line number Diff line
@@ -182,7 +182,8 @@ static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr, 
}



static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,

			     const char *buffer, size_t count) {

			     const char *buffer, size_t count)

{

	struct pcf2123_sysfs_reg *r;

	unsigned long reg;

	unsigned long val;
@@ -199,7 +200,7 @@ static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr, 
	if (ret)

		return ret;



	pcf2123_write_reg(dev, reg, val);

	ret = pcf2123_write_reg(dev, reg, val);

	if (ret < 0)

		return -EIO;

	return count;