Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8220ba3e authored by Stephen Boyd's avatar Stephen Boyd Committed by John W. Linville
Browse files

iwlegacy: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning 



Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following
warning:

In file included from arch/x86/include/asm/uaccess.h:573,
                 from include/net/checksum.h:25,
                 from include/linux/skbuff.h:28,
                 from drivers/net/wireless/iwlegacy/iwl-4965-rs.c:28:
In function 'copy_from_user',
    inlined from 'iwl4965_rs_sta_dbgfs_scale_table_write' at
    drivers/net/wireless/iwlegacy/iwl-4965-rs.c:2616:
arch/x86/include/asm/uaccess_64.h:65:
warning: call to 'copy_from_user_overflow' declared with
attribute warning: copy_from_user() buffer size is not provably
correct

presumably due to buf_size being signed causing GCC to fail to
see that buf_size can't become negative.

Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent b376704b

drivers/net/wireless/iwlegacy/iwl-4965-rs.c

+1 −1
Original line number Diff line number Diff line
@@ -2604,7 +2604,7 @@ static ssize_t iwl4965_rs_sta_dbgfs_scale_table_write(struct file *file, 
	struct iwl_lq_sta *lq_sta = file->private_data;

	struct iwl_priv *priv;

	char buf[64];

	int buf_size;

	size_t buf_size;

	u32 parsed_rate;

	struct iwl_station_priv *sta_priv =

		container_of(lq_sta, struct iwl_station_priv, lq_sta);