Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8211a7b5 authored by Troy Heber's avatar Troy Heber Committed by David Woodhouse
Browse files

pci/dmar: correct off-by-one error in dmar_fault() 



DMAR faults are recorded into a ring of "fault recording registers".
fault_index is a 0-based index into the ring. The code allows the
0-based fault_index to be equal to the total number of fault registers
available from the cap_num_fault_regs() macro, which causes access
beyond the last available register.

Signed-off-by Troy Heber <troy.heber@hp.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent 2ff729f5

drivers/pci/dmar.c

+1 −1
Original line number Diff line number Diff line
@@ -1226,7 +1226,7 @@ irqreturn_t dmar_fault(int irq, void *dev_id) 
				source_id, guest_addr);



		fault_index++;

		if (fault_index > cap_num_fault_regs(iommu->cap))

		if (fault_index >= cap_num_fault_regs(iommu->cap))

			fault_index = 0;

		spin_lock_irqsave(&iommu->register_lock, flag);

	}