Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 814ecf6e authored by Denis Kirjanov's avatar Denis Kirjanov Committed by Linus Torvalds
Browse files

sysctl_check: drop table->procname checks 



Since the for loop checks for the table->procname drop useless
table->procname checks inside the loop body

Signed-off-by: default avatarDenis Kirjanov <dkirjanov@kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ad4ac17a

kernel/sysctl_check.c

+2 −4
Original line number Diff line number Diff line
@@ -111,11 +111,9 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table) 
		const char *fail = NULL;



		if (table->parent) {

			if (table->procname && !table->parent->procname)

			if (!table->parent->procname)

				set_fail(&fail, table, "Parent without procname");

		}

		if (!table->procname)

			set_fail(&fail, table, "No procname");

		if (table->child) {

			if (table->data)

				set_fail(&fail, table, "Directory with data?");
@@ -144,7 +142,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table) 
					set_fail(&fail, table, "No maxlen");

			}

#ifdef CONFIG_PROC_SYSCTL

			if (table->procname && !table->proc_handler)

			if (!table->proc_handler)

				set_fail(&fail, table, "No proc_handler");

#endif

#if 0