Commit 80ca9a70 authored Jul 13, 2008 by Milton Miller Committed by Jaroslav Kysela Jul 14, 2008

ALSA: correct kcalloc usage



kcalloc is supposed to be called with the count as its first argument and the
element size as the second.

Both arguments are size_t so does not affect correctness.  This callsite is
during module_init and therefore not performance critical.  Another patch will
optimize the case when the count is variable but the size is fixed.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>

parent 862c2c0a

sound/pci/nm256/nm256.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1302,8 +1302,8 @@ snd_nm256_mixer(struct nm256 *chip)
		.read = snd_nm256_ac97_read,
		};

		chip->ac97_regs = kcalloc(sizeof(short),
		ARRAY_SIZE(nm256_ac97_init_val), GFP_KERNEL);
		chip->ac97_regs = kcalloc(ARRAY_SIZE(nm256_ac97_init_val),
		sizeof(short), GFP_KERNEL);
		if (! chip->ac97_regs)
		return -ENOMEM;