Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80b15043 authored by Wei Yongjun's avatar Wei Yongjun Committed by Roland Dreier
Browse files

IB/core: Fix error return code in add_port() 



Fix to return -ENOMEM in the add_port() error handling case instead of
0, as done elsewhere in this function.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent f29fa1cf

drivers/infiniband/core/sysfs.c

+6 −2
Original line number Original line Diff line number Diff line
@@ -545,8 +545,10 @@ static int add_port(struct ib_device *device, int port_num, 




	p->gid_group.name  = "gids";

	p->gid_group.name  = "gids";

	p->gid_group.attrs = alloc_group_attrs(show_port_gid, attr.gid_tbl_len);

	p->gid_group.attrs = alloc_group_attrs(show_port_gid, attr.gid_tbl_len);

	if (!p->gid_group.attrs)

	if (!p->gid_group.attrs) {

		ret = -ENOMEM;

		goto err_remove_pma;

		goto err_remove_pma;

	}





	ret = sysfs_create_group(&p->kobj, &p->gid_group);

	ret = sysfs_create_group(&p->kobj, &p->gid_group);

	if (ret)

	if (ret)
@@ -555,8 +557,10 @@ static int add_port(struct ib_device *device, int port_num, 
	p->pkey_group.name  = "pkeys";

	p->pkey_group.name  = "pkeys";

	p->pkey_group.attrs = alloc_group_attrs(show_port_pkey,

	p->pkey_group.attrs = alloc_group_attrs(show_port_pkey,

						attr.pkey_tbl_len);

						attr.pkey_tbl_len);

	if (!p->pkey_group.attrs)

	if (!p->pkey_group.attrs) {

		ret = -ENOMEM;

		goto err_remove_gid;

		goto err_remove_gid;

	}





	ret = sysfs_create_group(&p->kobj, &p->pkey_group);

	ret = sysfs_create_group(&p->kobj, &p->pkey_group);

	if (ret)

	if (ret)