Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80aaaa8b authored by Rafał Miłecki's avatar Rafał Miłecki Committed by Ralf Baechle
Browse files

MIPS: BCM47XX: Use strnchr to avoid reading out of the buffer 



Signed-off-by: default avatarRafał Miłecki <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/8662/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 23d2bc42

arch/mips/bcm47xx/nvram.c

+4 −2
Original line number Diff line number Diff line
@@ -175,7 +175,7 @@ static int nvram_init(void) 
int bcm47xx_nvram_getenv(const char *name, char *val, size_t val_len)

{

	char *var, *value, *end, *eq;

	int err;

	int data_left, err;



	if (!name)

		return -EINVAL;
@@ -191,7 +191,9 @@ int bcm47xx_nvram_getenv(const char *name, char *val, size_t val_len) 
	end = nvram_buf + sizeof(nvram_buf) - 2;

	end[0] = end[1] = '\0';

	for (; *var; var = value + strlen(value) + 1) {

		eq = strchr(var, '=');

		data_left = end - var;



		eq = strnchr(var, data_left, '=');

		if (!eq)

			break;

		value = eq + 1;