Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8084fe16 authored by Shyam Sundar's avatar Shyam Sundar Committed by James Bottomley
Browse files

[SCSI] qla2xxx: Validate mid-layer 'underflow' during check-condition handling. 



Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 5881569b

drivers/scsi/qla2xxx/qla_isr.c

+19 −0
Original line number Diff line number Diff line
@@ -1062,6 +1062,25 @@ qla2x00_status_entry(scsi_qla_host_t *ha, void *pkt) 
			    cp->device->id, cp->device->lun, cp,

			    cp->serial_number));



			/*

			 * In case of a Underrun condition, set both the lscsi

			 * status and the completion status to appropriate

			 * values.

			 */

			if (resid &&

			    ((unsigned)(cp->request_bufflen - resid) <

			     cp->underflow)) {

				DEBUG2(qla_printk(KERN_INFO, ha,

				    "scsi(%ld:%d:%d:%d): Mid-layer underflow "

				    "detected (%x of %x bytes)...returning "

				    "error status.\n", ha->host_no,

				    cp->device->channel, cp->device->id,

				    cp->device->lun, resid,

				    cp->request_bufflen));



				cp->result = DID_ERROR << 16 | lscsi_status;

			}



			if (sense_len)

				DEBUG5(qla2x00_dump_buffer(cp->sense_buffer,

				    CMD_ACTUAL_SNSLEN(cp)));