Commit 7fad948a authored Oct 22, 2015 by Julia Lawall Committed by Rob Herring Oct 22, 2015

of/platform: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
local idexpression n;
expression root,e;
@@

 for_each_child_of_node(root,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Rob Herring <robh@kernel.org>

parent 8363ccb9

drivers/of/platform.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -405,9 +405,11 @@ int of_platform_bus_probe(struct device_node *root,
		if (!of_match_node(matches, child))
		continue;
		rc = of_platform_bus_create(child, matches, NULL, parent, false);
		if (rc)
		if (rc) {
		of_node_put(child);
		break;
		}
		}

		of_node_put(root);
		return rc;
		@@ -447,9 +449,11 @@ int of_platform_populate(struct device_node *root,

		for_each_child_of_node(root, child) {
		rc = of_platform_bus_create(child, matches, lookup, parent, true);
		if (rc)
		if (rc) {
		of_node_put(child);
		break;
		}
		}
		of_node_set_flag(root, OF_POPULATED_BUS);

		of_node_put(root);