Commit 7f81dc00 authored Sep 19, 2006 by Chas Williams Committed by David S. Miller Sep 19, 2006

[ATM]: [he] don't hold the device lock when upcalling



This can create a deadlock/lock ordering problem with other layers
that want to use the transmit (or other) path of the card at that
time.

Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 79e453d4

drivers/atm/he.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1928,7 +1928,9 @@ he_service_rbrq(struct he_dev *he_dev, int group)
		#ifdef notdef
		ATM_SKB(skb)->vcc = vcc;
		#endif
		spin_unlock(&he_dev->global_lock);
		vcc->push(vcc, skb);
		spin_lock(&he_dev->global_lock);

		atomic_inc(&vcc->stats->rx);