Commit 7e800067 authored Mar 23, 2019 by Darrick J. Wong Committed by Greg Kroah-Hartman Apr 20, 2019

ext4: prohibit fstrim in norecovery mode



[ Upstream commit 18915b5873f07e5030e6fb108a050fa7c71c59fb ]

The ext4 fstrim implementation uses the block bitmaps to find free space
that can be discarded.  If we haven't replayed the journal, the bitmaps
will be stale and we absolutely *cannot* use stale metadata to zap the
underlying storage.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8b8b351a

fs/ext4/ioctl.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -749,6 +749,13 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
		if (!blk_queue_discard(q))
		return -EOPNOTSUPP;

		/*
		* We haven't replayed the journal, so we cannot use our
		* block-bitmap-guided storage zapping commands.
		*/
		if (test_opt(sb, NOLOAD) && ext4_has_feature_journal(sb))
		return -EROFS;

		if (copy_from_user(&range, (struct fstrim_range __user *)arg,
		sizeof(range)))
		return -EFAULT;