Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7e76ad43 authored by Xenia Ragiadakou's avatar Xenia Ragiadakou Committed by Sarah Sharp
Browse files

xhci: fix incorrect type in assignment in handle_device_notification() 



This patch converts Event TRB's 3rd field, which has type le32, to CPU
byteorder before using it to retrieve the Slot ID with TRB_TO_SLOT_ID macro.
This bug was found using sparse.

Signed-off-by: default avatarXenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
parent 58719487

drivers/usb/host/xhci-ring.c

+1 −1
Original line number Diff line number Diff line
@@ -1655,7 +1655,7 @@ static void handle_device_notification(struct xhci_hcd *xhci, 
	u32 slot_id;

	struct usb_device *udev;



	slot_id = TRB_TO_SLOT_ID(event->generic.field[3]);

	slot_id = TRB_TO_SLOT_ID(le32_to_cpu(event->generic.field[3]));

	if (!xhci->devs[slot_id]) {

		xhci_warn(xhci, "Device Notification event for "

				"unused slot %u\n", slot_id);