Commit 7d87d536 authored Dec 22, 2008 by Suresh Siddha Committed by Ingo Molnar Dec 23, 2008

x86: use logical apicid in x2apic_cluster's x2apic_cpu_mask_to_apicid_and()



These commits:

	commit 95d313cf
	Author: Mike Travis <travis@sgi.com>
	Date:   Tue Dec 16 17:33:54 2008 -0800

	    x86: Add cpu_mask_to_apicid_and

and
	commit 6eeb7c5a
	Author: Mike Travis <travis@sgi.com>
	Date:   Tue Dec 16 17:33:55 2008 -0800

	    x86: update add-cpu_mask_to_apicid_and to use struct cpumask*

broke interrupt delivery on x2apic platforms.  As x2apic cluster mode uses
logical delivery mode, we need to use logical apicid instead of physical apicid
in x2apic_cpu_mask_to_apicid_and()

Impact: fixes the broken interrupt delivery issue on generic x2apic platforms.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Acked-by: Mike Travis <travis@sgi.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 36dffab6

arch/x86/kernel/genx2apic_cluster.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -114,7 +114,7 @@ static unsigned int x2apic_cpu_mask_to_apicid(const struct cpumask *cpumask)
		int cpu;

		/*
		* We're using fixed IRQ delivery, can only return one phys APIC ID.
		* We're using fixed IRQ delivery, can only return one logical APIC ID.
		* May as well be the first.
		*/
		cpu = cpumask_first(cpumask);
		@@ -130,14 +130,14 @@ static unsigned int x2apic_cpu_mask_to_apicid_and(const struct cpumask *cpumask,
		int cpu;

		/*
		* We're using fixed IRQ delivery, can only return one phys APIC ID.
		* We're using fixed IRQ delivery, can only return one logical APIC ID.
		* May as well be the first.
		*/
		for_each_cpu_and(cpu, cpumask, andmask)
		if (cpumask_test_cpu(cpu, cpu_online_mask))
		break;
		if (cpu < nr_cpu_ids)
		return per_cpu(x86_cpu_to_apicid, cpu);
		return per_cpu(x86_cpu_to_logical_apicid, cpu);
		return BAD_APICID;
		}