Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ce529ef authored by Fabio Baltieri's avatar Fabio Baltieri
Browse files

dmaengine: ste_dma40: minor code readability fixes 



Use internal variables to the cycles to improve code readability, no
functional changes.

Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarVinod Koul <vinod.koul@intel.com>
Signed-off-by: default avatarFabio Baltieri <fabio.baltieri@linaro.org>
parent f26e03ad

drivers/dma/ste_dma40.c

+8 −9
Original line number Diff line number Diff line
@@ -639,19 +639,18 @@ static int d40_lcla_alloc_one(struct d40_chan *d40c, 
	unsigned long flags;

	int i;

	int ret = -EINVAL;

	int p;



	spin_lock_irqsave(&d40c->base->lcla_pool.lock, flags);



	p = d40c->phy_chan->num * D40_LCLA_LINK_PER_EVENT_GRP;



	/*

	 * Allocate both src and dst at the same time, therefore the half

	 * start on 1 since 0 can't be used since zero is used as end marker.

	 */

	for (i = 1 ; i < D40_LCLA_LINK_PER_EVENT_GRP / 2; i++) {

		if (!d40c->base->lcla_pool.alloc_map[p + i]) {

			d40c->base->lcla_pool.alloc_map[p + i] = d40d;

		int idx = d40c->phy_chan->num * D40_LCLA_LINK_PER_EVENT_GRP + i;



		if (!d40c->base->lcla_pool.alloc_map[idx]) {

			d40c->base->lcla_pool.alloc_map[idx] = d40d;

			d40d->lcla_alloc++;

			ret = i;

			break;
@@ -676,10 +675,10 @@ static int d40_lcla_free_all(struct d40_chan *d40c, 
	spin_lock_irqsave(&d40c->base->lcla_pool.lock, flags);



	for (i = 1 ; i < D40_LCLA_LINK_PER_EVENT_GRP / 2; i++) {

		if (d40c->base->lcla_pool.alloc_map[d40c->phy_chan->num *

						    D40_LCLA_LINK_PER_EVENT_GRP + i] == d40d) {

			d40c->base->lcla_pool.alloc_map[d40c->phy_chan->num *

							D40_LCLA_LINK_PER_EVENT_GRP + i] = NULL;

		int idx = d40c->phy_chan->num * D40_LCLA_LINK_PER_EVENT_GRP + i;



		if (d40c->base->lcla_pool.alloc_map[idx] == d40d) {

			d40c->base->lcla_pool.alloc_map[idx] = NULL;

			d40d->lcla_alloc--;

			if (d40d->lcla_alloc == 0) {

				ret = 0;