Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7cc36f6f authored by Kulikov Vasiliy's avatar Kulikov Vasiliy Committed by David S. Miller
Browse files

ll_temac: fix memory leak 



If of_iomap() or irq_of_parse_and_map() fail then np must be freed.

Signed-off-by: default avatarKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9f1e7582

drivers/net/ll_temac_main.c

+4 −1
Original line number Diff line number Diff line
@@ -1031,19 +1031,22 @@ temac_of_probe(struct of_device *op, const struct of_device_id *match) 
			dev_dbg(&op->dev, "MEM base: %p\n", lp->sdma_regs);

		} else {

			dev_err(&op->dev, "unable to map DMA registers\n");

			of_node_put(np);

			goto err_iounmap;

		}

	}



	lp->rx_irq = irq_of_parse_and_map(np, 0);

	lp->tx_irq = irq_of_parse_and_map(np, 1);



	of_node_put(np); /* Finished with the DMA node; drop the reference */



	if ((lp->rx_irq == NO_IRQ) || (lp->tx_irq == NO_IRQ)) {

		dev_err(&op->dev, "could not determine irqs\n");

		rc = -ENOMEM;

		goto err_iounmap_2;

	}



	of_node_put(np); /* Finished with the DMA node; drop the reference */



	/* Retrieve the MAC address */

	addr = of_get_property(op->dev.of_node, "local-mac-address", &size);