Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7c48ed33 authored by Ben Dooks's avatar Ben Dooks Committed by Linus Torvalds
Browse files

mmc: s3cmci: fix s3c2410_dma_config() arguments. 



The s3cmci driver is calling s3c2410_dma_config with incorrect data for
the DCON register.  The S3C2410_DCON_HWTRIG is implicit in the channel
configuration and the device selection of S3C2410_DCON_CH0_SDI is
incorrect as the DMA system may not select channel 0.

Signed-off-by: default avatarBen Dooks <ben@simtec.co.uk>
Acked-by: default avatarPierre Ossman <drzeus@drzeus.cx>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1b53dc74

drivers/mmc/host/s3cmci.c

+1 −2
Original line number Diff line number Diff line
@@ -793,8 +793,7 @@ static void s3cmci_dma_setup(struct s3cmci_host *host, 
			      host->mem->start + host->sdidata);



	if (!setup_ok) {

		s3c2410_dma_config(host->dma, 4,

			(S3C2410_DCON_HWTRIG | S3C2410_DCON_CH0_SDI));

		s3c2410_dma_config(host->dma, 4, 0);

		s3c2410_dma_set_buffdone_fn(host->dma,

					    s3cmci_dma_done_callback);

		s3c2410_dma_setflags(host->dma, S3C2410_DMAF_AUTOSTART);