Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b63c577 authored by Devendra Naga's avatar Devendra Naga Committed by Greg Kroah-Hartman
Browse files

staging: dgrp: check for a valid proc dir entry pointer



while proc_create fails, the register_proc_table can do a derefernce of the
null pointer causing to oops the system, instead check for a valid pointer
at register and unregister

Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b194218d
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -181,13 +181,13 @@ static struct dgrp_proc_entry dgrp_dpa_table[] = {

void dgrp_unregister_proc(void)
{
	unregister_proc_table(dgrp_table, dgrp_proc_dir_entry);
	net_entry_pointer = NULL;
	mon_entry_pointer = NULL;
	dpa_entry_pointer = NULL;
	ports_entry_pointer = NULL;

	if (dgrp_proc_dir_entry) {
		unregister_proc_table(dgrp_table, dgrp_proc_dir_entry);
		remove_proc_entry(dgrp_proc_dir_entry->name,
				  dgrp_proc_dir_entry->parent);
		dgrp_proc_dir_entry = NULL;
@@ -231,6 +231,8 @@ static void register_proc_table(struct dgrp_proc_entry *table,

	if (table == NULL)
		return;
	if (root == NULL)
		return;

	for (; table->id; table++) {
		/* Can't do anything without a proc name. */