Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7aab449e authored by Stanislav Kinsbursky's avatar Stanislav Kinsbursky Committed by Trond Myklebust
Browse files

SUNRPC: skip clients with program without PipeFS entries 



1) This is sane.
2) Otherwise there will be soft lockup:

do {
	rpc_get_client_for_event (clnt->cl_dentry == NULL ==> choose)
	__rpc_pipefs_event (clnt->cl_program->pipe_dir_name == NULL ==> return)
} while (1)

Signed-off-by: default avatarStanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent a4dff1bc

net/sunrpc/clnt.c

+2 −2
Original line number Diff line number Diff line
@@ -184,8 +184,6 @@ static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event, 


	switch (event) {

	case RPC_PIPEFS_MOUNT:

		if (clnt->cl_program->pipe_dir_name == NULL)

			break;

		dentry = rpc_setup_pipedir_sb(sb, clnt,

					      clnt->cl_program->pipe_dir_name);

		BUG_ON(dentry == NULL);
@@ -215,6 +213,8 @@ static struct rpc_clnt *rpc_get_client_for_event(struct net *net, int event) 


	spin_lock(&sn->rpc_client_lock);

	list_for_each_entry(clnt, &sn->all_clients, cl_clients) {

		if (clnt->cl_program->pipe_dir_name == NULL)

			break;

		if (((event == RPC_PIPEFS_MOUNT) && clnt->cl_dentry) ||

		    ((event == RPC_PIPEFS_UMOUNT) && !clnt->cl_dentry))

			continue;