Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a7ee531 authored by Scott Feldman's avatar Scott Feldman Committed by David S. Miller
Browse files

switchdev: sparse warning: pass ipv4 fib dst as network-byte order 



And let driver convert it to host-byte order as needed.

Signed-off-by: default avatarScott Feldman <sfeldma@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 22c1f67e

drivers/net/ethernet/rocker/rocker.c

+4 −3
Original line number Diff line number Diff line
@@ -4471,7 +4471,7 @@ static int rocker_port_obj_add(struct net_device *dev, 
	case SWITCHDEV_OBJ_IPV4_FIB:

		fib4 = &obj->ipv4_fib;

		err = rocker_port_fib_ipv4(rocker_port, obj->trans,

					   fib4->dst, fib4->dst_len,

					   htonl(fib4->dst), fib4->dst_len,

					   fib4->fi, fib4->tb_id, 0);

		break;

	default:
@@ -4525,8 +4525,9 @@ static int rocker_port_obj_del(struct net_device *dev, 
	case SWITCHDEV_OBJ_IPV4_FIB:

		fib4 = &obj->ipv4_fib;

		err = rocker_port_fib_ipv4(rocker_port, SWITCHDEV_TRANS_NONE,

					   fib4->dst, fib4->dst_len, fib4->fi,

					   fib4->tb_id, ROCKER_OP_FLAG_REMOVE);

					   htonl(fib4->dst), fib4->dst_len,

					   fib4->fi, fib4->tb_id,

					   ROCKER_OP_FLAG_REMOVE);

		break;

	default:

		err = -EOPNOTSUPP;

net/switchdev/switchdev.c

+2 −2
Original line number Diff line number Diff line
@@ -645,7 +645,7 @@ int switchdev_fib_ipv4_add(u32 dst, int dst_len, struct fib_info *fi, 
	struct switchdev_obj fib_obj = {

		.id = SWITCHDEV_OBJ_IPV4_FIB,

		.ipv4_fib = {

			.dst = htonl(dst),

			.dst = dst,

			.dst_len = dst_len,

			.fi = fi,

			.tos = tos,
@@ -699,7 +699,7 @@ int switchdev_fib_ipv4_del(u32 dst, int dst_len, struct fib_info *fi, 
	struct switchdev_obj fib_obj = {

		.id = SWITCHDEV_OBJ_IPV4_FIB,

		.ipv4_fib = {

			.dst = htonl(dst),

			.dst = dst,

			.dst_len = dst_len,

			.fi = fi,

			.tos = tos,