Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a74c481 authored by Ricardo Ribalda Delgado's avatar Ricardo Ribalda Delgado Committed by Felipe Balbi
Browse files

usb: gadget: udc: net2280: remove full_speed module parameter



This patch removes the full_speed parameter used force full-speed
operation.

It was designed exclusively for testing purposes, and there is no
reason to maintain this in a production kernel.

Reverts: 2f076077
Suggested-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 90664198
Loading
Loading
Loading
Loading
+1 −17
Original line number Diff line number Diff line
@@ -113,11 +113,6 @@ static bool enable_suspend;
/* "modprobe net2280 enable_suspend=1" etc */
module_param(enable_suspend, bool, 0444);

/* force full-speed operation */
static bool full_speed;
module_param(full_speed, bool, 0444);
MODULE_PARM_DESC(full_speed, "force full-speed mode -- for testing only!");

#define	DIR_STRING(bAddress) (((bAddress) & USB_DIR_IN) ? "in" : "out")

static char *type_string(u8 bmAttributes)
@@ -2291,11 +2286,7 @@ static int net2280_start(struct usb_gadget *_gadget,
	if (retval)
		goto err_func;

	/* Enable force-full-speed testing mode, if desired */
	if (full_speed && (dev->quirks & PLX_LEGACY))
		writel(BIT(FORCE_FULL_SPEED_MODE), &dev->usb->xcvrdiag);

	/* ... then enable host detection and ep0; and we're ready
	/* enable host detection and ep0; and we're ready
	 * for set_configuration as well as eventual disconnect.
	 */
	net2280_led_active(dev, 1);
@@ -2353,10 +2344,6 @@ static int net2280_stop(struct usb_gadget *_gadget)

	net2280_led_active(dev, 0);

	/* Disable full-speed test mode */
	if (dev->quirks & PLX_LEGACY)
		writel(0, &dev->usb->xcvrdiag);

	device_remove_file(&dev->pdev->dev, &dev_attr_function);
	device_remove_file(&dev->pdev->dev, &dev_attr_queues);

@@ -3655,9 +3642,6 @@ static void net2280_shutdown(struct pci_dev *pdev)
	/* disable the pullup so the host will think we're gone */
	writel(0, &dev->usb->usbctl);

	/* Disable full-speed test mode */
	if (dev->quirks & PLX_LEGACY)
		writel(0, &dev->usb->xcvrdiag);
}