Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a12f4b5 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB: drivers/media/video/zoran: Use kmemdup 

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDouglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent cd3172d7

drivers/media/video/zoran/videocodec.c

+2 −3
Original line number Diff line number Diff line
@@ -107,15 +107,14 @@ videocodec_attach (struct videocodec_master *master) 
			if (!try_module_get(h->codec->owner))

				return NULL;



			codec =

			    kmalloc(sizeof(struct videocodec), GFP_KERNEL);

			codec = kmemdup(h->codec, sizeof(struct videocodec),

					GFP_KERNEL);

			if (!codec) {

				dprintk(1,

					KERN_ERR

					"videocodec_attach: no mem\n");

				goto out_module_put;

			}

			memcpy(codec, h->codec, sizeof(struct videocodec));



			snprintf(codec->name, sizeof(codec->name),

				 "%s[%d]", codec->name, h->attached);