Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79186876 authored by Artem Bityutskiy's avatar Artem Bityutskiy Committed by David Woodhouse
Browse files

mtd: mtdconcat: return -EOPNOTSUPP if block_markbad is undefined 



The main 'mtd_block_markbad()' function returns -EOPNOTSUPP if the
'->block_markbad' method is undefined, and mtdconcat should do the same.
Fix this by simply removing the 'mtd_can_have_bb()' because it is  not
really necessary. It could be treated as an optimization, but this function is
expected to be used so rarely that it does not matter.

Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent c4cc625e

drivers/mtd/mtdconcat.c

+0 −3
Original line number Diff line number Diff line
@@ -673,9 +673,6 @@ static int concat_block_markbad(struct mtd_info *mtd, loff_t ofs) 
	struct mtd_concat *concat = CONCAT(mtd);

	int i, err = -EINVAL;



	if (!mtd_can_have_bb(concat->subdev[0]))

		return 0;



	if (ofs > mtd->size)

		return -EINVAL;