Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78d04af4 authored by Trond Myklebust's avatar Trond Myklebust Committed by Anna Schumaker
Browse files

NFS: nfs_prime_dcache must validate the filename 



Before we try to stash it in the dcache, we need to at least check
that the filename passed to us by the server is non-empty and doesn't
contain any illegal '\0' or '/' characters.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent a1d617d8

fs/nfs/dir.c

+8 −0
Original line number Diff line number Diff line
@@ -496,6 +496,14 @@ void nfs_prime_dcache(struct dentry *parent, struct nfs_entry *entry) 
		return;

	if (!(entry->fattr->valid & NFS_ATTR_FATTR_FSID))

		return;

	if (filename.len == 0)

		return;

	/* Validate that the name doesn't contain any illegal '\0' */

	if (strnlen(filename.name, filename.len) != filename.len)

		return;

	/* ...or '/' */

	if (strnchr(filename.name, filename.len, '/'))

		return;

	if (filename.name[0] == '.') {

		if (filename.len == 1)

			return;