Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77a83ed1 authored by Sebastian Ott's avatar Sebastian Ott Committed by David S. Miller
Browse files

s390/qeth: fix indentation in qeth_l3_arp_query 



gcc-6 warns about obviously wrong indentation:
drivers/s390/net/qeth_l3_main.c: In function 'qeth_l3_arp_query':
drivers/s390/net/qeth_l3_main.c:2315:3: warning: this 'if' clause does not
guard... [-Wmisleading-indentation]
   if (copy_to_user(udata, qinfo.udata, 4))
   ^~
drivers/s390/net/qeth_l3_main.c:2317:4: note: ...this statement, but the
latter is misleadingly indented as if it is guarded by the 'if'
    goto free_and_out;
    ^~~~

Although this particular case is harmless, fix the indentation to get rid
of that warning and improve readability.

Signed-off-by: default avatarSebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 70deb016

drivers/s390/net/qeth_l3_main.c

+12 −13
Original line number Diff line number Diff line
@@ -2315,12 +2315,11 @@ static int qeth_l3_arp_query(struct qeth_card *card, char __user *udata) 
		if (copy_to_user(udata, qinfo.udata, 4))

			rc = -EFAULT;

		goto free_and_out;

	} else {

	}

#ifdef CONFIG_QETH_IPV6

	if (qinfo.mask_bits & QETH_QARP_WITH_IPV6) {

		/* fails in case of GuestLAN QDIO mode */

			qeth_l3_query_arp_cache_info(card, QETH_PROT_IPV6,

				&qinfo);

		qeth_l3_query_arp_cache_info(card, QETH_PROT_IPV6, &qinfo);

	}

#endif

	if (copy_to_user(udata, qinfo.udata, qinfo.udata_len)) {
@@ -2329,7 +2328,7 @@ static int qeth_l3_arp_query(struct qeth_card *card, char __user *udata) 
		goto free_and_out;

	}

	QETH_CARD_TEXT(card, 4, "qacts");

	}



free_and_out:

	kfree(qinfo.udata);

out: