Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7663cfd3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jason Cooper
Browse files

bus: mvebu-mbus: potential forever loop in mvebu_mbus_init() 



"of_id->compatible" is an array and not a pointer so it can never be
NULL.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: default avatarJason Cooper <jason@lakedaemon.net>
parent 6ce4eac1

drivers/bus/mvebu-mbus.c

+2 −2
Original line number Diff line number Diff line
@@ -734,11 +734,11 @@ int __init mvebu_mbus_init(const char *soc, phys_addr_t mbuswins_phys_base, 
{

	const struct of_device_id *of_id;



	for (of_id = of_mvebu_mbus_ids; of_id->compatible; of_id++)

	for (of_id = of_mvebu_mbus_ids; of_id->compatible[0]; of_id++)

		if (!strcmp(of_id->compatible, soc))

			break;



	if (!of_id->compatible) {

	if (!of_id->compatible[0]) {

		pr_err("could not find a matching SoC family\n");

		return -ENODEV;

	}