Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75bc5fad authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: gdm724x: cleanup alloc_tx_sdu_struct() 



The kfree(t_sdu->buf) sets off a private static checker warning because
"t_sdu->buf" is always NULL.

This function just allocates two pointers so we can re-write it to be
simpler.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a469fe1a

drivers/staging/gdm724x/gdm_usb.c

+4 −17
Original line number Diff line number Diff line
@@ -119,28 +119,15 @@ static struct usb_tx *alloc_tx_struct(int len) 


static struct usb_tx_sdu *alloc_tx_sdu_struct(void)

{

	struct usb_tx_sdu *t_sdu = NULL;

	int ret = 0;



	struct usb_tx_sdu *t_sdu;



	t_sdu = kzalloc(sizeof(struct usb_tx_sdu), GFP_ATOMIC);

	if (!t_sdu) {

		ret = -ENOMEM;

		goto out;

	}

	if (!t_sdu)

		return NULL;



	t_sdu->buf = kmalloc(SDU_BUF_SIZE, GFP_ATOMIC);

	if (!t_sdu->buf) {

		ret = -ENOMEM;

		goto out;

	}

out:



	if (ret < 0) {

		if (t_sdu) {

			kfree(t_sdu->buf);

		kfree(t_sdu);

		}

		return NULL;

	}