Commit 753a8970 authored Apr 23, 2010 by Peter Hurley Committed by Stefan Richter May 19, 2010

firewire: core: Fix tlabel exhaustion problem



fw_core_handle_response() was not properly clearing tlabel_mask. This
was resulting in premature tlabel exhaustion.

Signed-off-by: Peter Hurley <phurley@charter.net>

This fixes an omission in 2.6.31-rc1 commit 1e626fdc "firewire: core:
use more outbound tlabels" which prevented to really use 64 instead of
32 transaction labels, as soon as split transactions occurred that had
their AR-resp tasklet run after the AT-req tasklet.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

parent 7906054f

drivers/firewire/core-transaction.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -842,7 +842,7 @@ void fw_core_handle_response(struct fw_card card, struct fw_packet p)
		list_for_each_entry(t, &card->transaction_list, link) {
		if (t->node_id == source && t->tlabel == tlabel) {
		list_del(&t->link);
		card->tlabel_mask &= ~(1 << t->tlabel);
		card->tlabel_mask &= ~(1ULL << t->tlabel);
		break;
		}
		}