Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7525c85b authored by Roland Dreier's avatar Roland Dreier
Browse files

RDMA/nes: Add missing rcu_read_unlock() in nes_addr_resolve_neigh() 



Make sure all exit paths from this function unlock everything.

Reported-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 81f99dcc

drivers/infiniband/hw/nes/nes_cm.c

+3 −2
Original line number Diff line number Diff line
@@ -1363,8 +1363,7 @@ static int nes_addr_resolve_neigh(struct nes_vnic *nesvnic, u32 dst_ip, int arpi 
				if (!memcmp(nesadapter->arp_table[arpindex].mac_addr,

					    neigh->ha, ETH_ALEN)) {

					/* Mac address same as in nes_arp_table */

					ip_rt_put(rt);

					return rc;

					goto out;

				}



				nes_manage_arp_cache(nesvnic->netdev,
@@ -1380,6 +1379,8 @@ static int nes_addr_resolve_neigh(struct nes_vnic *nesvnic, u32 dst_ip, int arpi 
			neigh_event_send(neigh, NULL);

		}

	}



out:

	rcu_read_unlock();

	ip_rt_put(rt);

	return rc;