Commit 746b31a9 authored Jan 17, 2008 by Andres Salomon Committed by Dmitry Torokhov Jan 17, 2008

Input: psmouse - fix potential memory leak in psmouse_connect()



If we successfully call input_register_device() in psmouse_connect()
but sysfs_create_group() fails, we'll enter the error path without
ever having called input_unregister_device() potentially leaking
memory.

Signed-off-by: Andres Salomon <dilinger@debian.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

parent 62aa366d

drivers/input/mouse/psmouse-base.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1247,6 +1247,8 @@ static int psmouse_connect(struct serio serio, struct serio_driver drv)
		err_pt_deactivate:
		if (parent && parent->pt_deactivate)
		parent->pt_deactivate(parent);
		input_unregister_device(psmouse->dev);
		input_dev = NULL; /* so we don't try to free it below */
		err_protocol_disconnect:
		if (psmouse->disconnect)
		psmouse->disconnect(psmouse);