Commit 740b48be authored Jun 22, 2012 by H Hartley Sweeten Committed by Greg Kroah-Hartman Jun 22, 2012

staging: comedi: ni_daq_700: fix return for insn_config function

The comedi insn_config functions should return < 0 for errors or
the number of data elements used to perform the command, this value
is available as 'insn->n'. Return that instead of the open coded
number to better indicate what the return means.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c11a1ea7

drivers/staging/comedi/drivers/ni_daq_700.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -89,13 +89,12 @@ static int subdev_700_insn_config(struct comedi_device *dev,
		break;
		case INSN_CONFIG_DIO_QUERY:
		data[1] = (s->io_bits & chan) ? COMEDI_OUTPUT : COMEDI_INPUT;
		return insn->n;
		break;
		default:
		return -EINVAL;
		}

		return 1;
		return insn->n;
		}

		static int dio700_attach(struct comedi_device dev, struct comedi_devconfig it)