Commit 736c4b85 authored Dec 06, 2006 by Mika Kukkonen Committed by Linus Torvalds Dec 07, 2006

[PATCH] Function v9fs_get_idpool returns int, not u32 as called twice in fs/9p/vfs_inode.c

Function v9fs_get_idpool returns int, not u32.  Actually it returns -1 on
errors, and these two callers check if the value is smaller than 0, which
was caught by gcc with extra warning flags.  Compile tested only but should
be OK, as the value computed in v9fs_get_idpool() is also int.

Signed-of-by: Mika Kukkonen <mikukkon@iki.fi>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@lanl.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 3316eaa3

fs/9p/vfs_inode.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -256,7 +256,7 @@ static int
		v9fs_create(struct v9fs_session_info v9ses, u32 pfid, char name, u32 perm,
		u8 mode, char extension, u32 fidp, struct v9fs_qid qid, u32 iounit)
		{
		u32 fid;
		int fid;
		int err;
		struct v9fs_fcall *fcall;

		@@ -310,7 +310,7 @@ static struct v9fs_fid*
		v9fs_clone_walk(struct v9fs_session_info v9ses, u32 fid, struct dentry dentry)
		{
		int err;
		u32 nfid;
		int nfid;
		struct v9fs_fid *ret;
		struct v9fs_fcall *fcall;