Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72c3500a authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter
Browse files

drm/i915: Add a note explaining vdd on/off handling in intel_dp_aux_ch() 



Add a comment to explain why we care about the current want_panel_vdd
state in intel_dp_aux_ch().

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 1e0560e0

drivers/gpu/drm/i915/intel_dp.c

+6 −0
Original line number Diff line number Diff line
@@ -533,6 +533,12 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, 
	bool has_aux_irq = HAS_AUX_IRQ(dev);

	bool vdd;



	/*

	 * We will be called with VDD already enabled for dpcd/edid/oui reads.

	 * In such cases we want to leave VDD enabled and it's up to upper layers

	 * to turn it off. But for eg. i2c-dev access we need to turn it on/off

	 * ourselves.

	 */

	vdd = edp_panel_vdd_on(intel_dp);



	/* dp aux is extremely sensitive to irq latency, hence request the