Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7219a58c authored by Amit Cohen's avatar Amit Cohen Committed by Greg Kroah-Hartman
Browse files

mlxsw: spectrum: Prevent force of 56G 



[ Upstream commit 275e928f19117d22f6d26dee94548baf4041b773 ]

Force of 56G is not supported by hardware in Ethernet devices. This
configuration fails with a bad parameter error from firmware.

Add check of this case. Instead of trying to set 56G with autoneg off,
return a meaningful error.

Fixes: 56ade8fe ("mlxsw: spectrum: Add initial support for Spectrum ASIC")
Signed-off-by: default avatarAmit Cohen <amitc@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1d28cf14

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+4 −0
Original line number Diff line number Diff line
@@ -2044,6 +2044,10 @@ mlxsw_sp_port_set_link_ksettings(struct net_device *dev, 
	mlxsw_reg_ptys_unpack(ptys_pl, &eth_proto_cap, NULL, NULL);



	autoneg = cmd->base.autoneg == AUTONEG_ENABLE;

	if (!autoneg && cmd->base.speed == SPEED_56000) {

		netdev_err(dev, "56G not supported with autoneg off\n");

		return -EINVAL;

	}

	eth_proto_new = autoneg ?

		mlxsw_sp_to_ptys_advert_link(cmd) :

		mlxsw_sp_to_ptys_speed(cmd->base.speed);