Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 719be629 authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds
Browse files

aacraid: fix security hole 



On the SCSI layer ioctl path there is no implicit permissions check for
ioctls (and indeed other drivers implement unprivileged ioctls). aacraid
however allows all sorts of very admin only things to be done so should
check.

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Acked-by: default avatarMark Salyzyn <mark_salyzyn@adaptec.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6e8a43c8

drivers/scsi/aacraid/linit.c

+4 −0
Original line number Diff line number Diff line
@@ -636,6 +636,8 @@ static int aac_cfg_open(struct inode *inode, struct file *file) 
static int aac_cfg_ioctl(struct inode *inode,  struct file *file,

		unsigned int cmd, unsigned long arg)

{

	if (!capable(CAP_SYS_ADMIN))

		return -EPERM;

	return aac_do_ioctl(file->private_data, cmd, (void __user *)arg);

}
@@ -689,6 +691,8 @@ static int aac_compat_ioctl(struct scsi_device *sdev, int cmd, void __user *arg) 


static long aac_compat_cfg_ioctl(struct file *file, unsigned cmd, unsigned long arg)

{

	if (!capable(CAP_SYS_ADMIN))

		return -EPERM;

	return aac_compat_do_ioctl((struct aac_dev *)file->private_data, cmd, arg);

}

#endif