Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71892418 authored by Sebastian Herbszt's avatar Sebastian Herbszt Committed by Martin K. Petersen
Browse files

lpfc: remove incorrect lockdep assertion 



Remove incorrect lockdep assertion from lpfc_sli_hbqbuf_find() which
acquires the hbalock itself. Fix the comment which resulted in this
mistake.

Fixes: 1c2ba475 ("lpfc: Add lockdep assertions")
Signed-off-by: default avatarSebastian Herbszt <herbszt@gmx.de>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9c8a76d5

drivers/scsi/lpfc/lpfc_sli.c

+3 −6
Original line number Diff line number Diff line
@@ -2000,10 +2000,9 @@ lpfc_sli_hbqbuf_get(struct list_head *rb_list) 
 * @phba: Pointer to HBA context object.

 * @tag: Tag of the hbq buffer.

 *

 * This function is called with hbalock held. This function searches

 * for the hbq buffer associated with the given tag in the hbq buffer

 * list. If it finds the hbq buffer, it returns the hbq_buffer other wise

 * it returns NULL.

 * This function searches for the hbq buffer associated with the given tag in

 * the hbq buffer list. If it finds the hbq buffer, it returns the hbq_buffer

 * otherwise it returns NULL.

 **/

static struct hbq_dmabuf *

lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag)
@@ -2012,8 +2011,6 @@ lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag) 
	struct hbq_dmabuf *hbq_buf;

	uint32_t hbqno;













	lockdep_assert_held(&phba->hbalock);



























	hbqno = tag >> 16;















	if (hbqno >= LPFC_MAX_HBQS)















		return NULL;