Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71864b22 authored by Wei Yongjun's avatar Wei Yongjun Committed by Mark Brown
Browse files

ASoC: samsung: Fix return value check in s3c2412_iis_dev_probe() 



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR(). Also remove redundant return value check of
platform_get_resource().

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent dd2380e3

sound/soc/samsung/s3c2412-i2s.c

+2 −6
Original line number Diff line number Diff line
@@ -154,13 +154,9 @@ static int s3c2412_iis_dev_probe(struct platform_device *pdev) 
	struct resource *res;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!res) {

		dev_err(&pdev->dev, "Can't get IO resource.\n");

		return -ENOENT;

	}

	s3c2412_i2s.regs = devm_ioremap_resource(&pdev->dev, res);

	if (s3c2412_i2s.regs == NULL)

		return -ENXIO;

	if (IS_ERR(s3c2412_i2s.regs))

		return PTR_ERR(s3c2412_i2s.regs);



	s3c2412_i2s_pcm_stereo_out.dma_addr = res->start + S3C2412_IISTXD;

	s3c2412_i2s_pcm_stereo_in.dma_addr = res->start + S3C2412_IISRXD;