Commit 71306671 authored Apr 22, 2005 by Arun Sharma Committed by Tony Luck Apr 22, 2005

[IA64] ia32_signal.c: erroneous use of memset/memcpy



Found by Alexander Nyberg, improved by Bjorn Helgaas.

- Fix the incorrect argument to sizeof()
- looks like memcpy() code pass was dervived from code that used
  copy_from_user().  But in this case we are doing to kernel space
  to kernel space copy, so memcpy is the right routine, but it
  doesn't return an error code.
 
Signed-off-by: Arun Sharma <arun.sharma@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>

parent efab7739

arch/ia64/ia32/ia32_signal.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -460,10 +460,9 @@ __ia32_rt_sigsuspend (compat_sigset_t *sset, unsigned int sigsetsize, struct sig
		sigset_t oldset, set;

		scr->scratch_unat = 0; /* avoid leaking kernel bits to user level */
		memset(&set, 0, sizeof(&set));
		memset(&set, 0, sizeof(set));

		if (memcpy(&set.sig, &sset->sig, sigsetsize))
		return -EFAULT;
		memcpy(&set.sig, &sset->sig, sigsetsize);

		sigdelsetmask(&set, ~_BLOCKABLE);