Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 70dda99c authored by Yaniv Rosner's avatar Yaniv Rosner Committed by David S. Miller
Browse files

bnx2x: Fix port identification problem 



This patch fixes port identification on optic devices when there's no link on the port.

Signed-off-by: default avatarYaniv Rosner <yanivr@broadcom.com>
Signed-off-by: default avatarEilon Greenstein <eilong@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c8a75b34

drivers/net/bnx2x/bnx2x_ethtool.c

+4 −5
Original line number Diff line number Diff line
@@ -2114,19 +2114,18 @@ static int bnx2x_phys_id(struct net_device *dev, u32 data) 
	for (i = 0; i < (data * 2); i++) {

		if ((i % 2) == 0)

			bnx2x_set_led(&bp->link_params, &bp->link_vars,

				      LED_MODE_OPER, SPEED_1000);

				      LED_MODE_ON, SPEED_1000);

		else

			bnx2x_set_led(&bp->link_params, &bp->link_vars,

				      LED_MODE_OFF, 0);

				      LED_MODE_FRONT_PANEL_OFF, 0);



		msleep_interruptible(500);

		if (signal_pending(current))

			break;

	}



	if (bp->link_vars.link_up)

		bnx2x_set_led(&bp->link_params, &bp->link_vars, LED_MODE_OPER,

			      bp->link_vars.line_speed);

	bnx2x_set_led(&bp->link_params, &bp->link_vars,

		      LED_MODE_OPER, bp->link_vars.line_speed);



	return 0;

}