Commit 70843f62 authored May 10, 2014 by Vivek Gautam Committed by Greg Kroah-Hartman May 27, 2014

usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap



Using devm_ioremap_resource() API should actually be preferred over
devm_ioremap(), since the former request the mem region first and then
gives back the ioremap'ed memory pointer.
devm_ioremap_resource() calls request_mem_region(), therby preventing
other drivers to make any overlapping call to the same region.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4e24bde3

drivers/usb/host/ehci-msm.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -96,10 +96,9 @@ static int ehci_msm_probe(struct platform_device *pdev)

		hcd->rsrc_start = res->start;
		hcd->rsrc_len = resource_size(res);
		hcd->regs = devm_ioremap(&pdev->dev, hcd->rsrc_start, hcd->rsrc_len);
		if (!hcd->regs) {
		dev_err(&pdev->dev, "ioremap failed\n");
		ret = -ENOMEM;
		hcd->regs = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(hcd->regs)) {
		ret = PTR_ERR(hcd->regs);
		goto put_hcd;
		}